linux-kernel - Re: [PATCH] samples/bpf: Remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4Bzam6bRX+e5ZcQD-px59Fij_O6dZvk6VsKHZhDMURt7W_g@mail.gmail.com>
Date: Wed, 13 Nov 2024 12:41:57 -0800
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Zhu Jun <zhujun2@...s.chinamobile.com>
Cc: martin.lau@...ux.dev, eddyz87@...il.com, yonghong.song@...ux.dev, 
	john.fastabend@...il.com, sdf@...ichev.me, haoluo@...gle.com, 
	jolsa@...nel.org, bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] samples/bpf: Remove unused variables

On Sun, Nov 10, 2024 at 10:23 PM Zhu Jun <zhujun2@...s.chinamobile.com> wrote:
>
> These variables are never referenced in the code, just remove them
>
> Signed-off-by: Zhu Jun <zhujun2@...s.chinamobile.com>
> ---
>  samples/bpf/tc_l2_redirect_kern.c | 4 ----
>  1 file changed, 4 deletions(-)
>

applied to bpf-next (but added file name to subject, so not sure if
bot will pick this up)

> diff --git a/samples/bpf/tc_l2_redirect_kern.c b/samples/bpf/tc_l2_redirect_kern.c
> index fd2fa0004330..729657d77802 100644
> --- a/samples/bpf/tc_l2_redirect_kern.c
> +++ b/samples/bpf/tc_l2_redirect_kern.c
> @@ -64,8 +64,6 @@ int _l2_to_iptun_ingress_forward(struct __sk_buff *skb)
>         void *data_end = (void *)(long)skb->data_end;
>         int key = 0, *ifindex;
>
> -       int ret;
> -
>         if (data + sizeof(*eth) > data_end)
>                 return TC_ACT_OK;
>
> @@ -115,8 +113,6 @@ int _l2_to_iptun_ingress_redirect(struct __sk_buff *skb)
>         void *data_end = (void *)(long)skb->data_end;
>         int key = 0, *ifindex;
>
> -       int ret;
> -
>         if (data + sizeof(*eth) > data_end)
>                 return TC_ACT_OK;
>
> --
> 2.17.1
>
>
>
>