[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241113211330.hd6y32gfy4hbwqfm@jpoimboe>
Date: Wed, 13 Nov 2024 13:13:30 -0800
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Jens Remus <jremus@...ux.ibm.com>, x86@...nel.org,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...nel.org>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
linux-kernel@...r.kernel.org, Indu Bhagat <indu.bhagat@...cle.com>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
Ian Rogers <irogers@...gle.com>,
Adrian Hunter <adrian.hunter@...el.com>,
linux-perf-users@...r.kernel.org, Mark Brown <broonie@...nel.org>,
linux-toolchains@...r.kernel.org, Jordan Rome <jordalgo@...a.com>,
Sam James <sam@...too.org>, linux-trace-kernel@...r.kerne.org,
Andrii Nakryiko <andrii.nakryiko@...il.com>,
Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
Florian Weimer <fweimer@...hat.com>,
Andy Lutomirski <luto@...nel.org>
Subject: Re: [PATCH v3 09/19] unwind: Introduce sframe user space unwinding
On Wed, Nov 13, 2024 at 03:50:58PM -0500, Steven Rostedt wrote:
> On Wed, 13 Nov 2024 16:56:25 +0100
> Jens Remus <jremus@...ux.ibm.com> wrote:
>
> > On 28.10.2024 22:47, Josh Poimboeuf wrote:
> >
> > > diff --git a/kernel/unwind/user.c b/kernel/unwind/user.c
> >
> > > @@ -68,7 +83,12 @@ int unwind_user_start(struct unwind_user_state *state)
> > > return -EINVAL;
> > > }
> > >
> > > - state->type = UNWIND_USER_TYPE_FP;
> > > + if (current_has_sframe())
> > > + state->type = UNWIND_USER_TYPE_SFRAME;
> > > + else if (IS_ENABLED(CONFIG_UNWIND_USER_FP))
> >
> > The test must be for CONFIG_HAVE_UNWIND_USER_FP. :-)
>
> Yep, that too.
I also found this one, so that makes three of us!
It's too bad IS_ENABLED() doesn't catch typos.
--
Josh
Powered by blists - more mailing lists