linux-kernel - Re: [PATCH net v4 1/7] octeon_ep: Add checks to fix double free crashes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03ccdc24-27af-4b4e-baf3-40d89ae72e99@linux.dev>
Date: Wed, 13 Nov 2024 22:38:53 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Shinas Rasheed <srasheed@...vell.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: hgani@...vell.com, sedara@...vell.com, vimleshk@...vell.com,
 thaller@...hat.com, wizhao@...hat.com, kheib@...hat.com, egallen@...hat.com,
 konguyen@...hat.com, horms@...nel.org,
 Veerasenareddy Burru <vburru@...vell.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Abhijit Ayarekar <aayarekar@...vell.com>,
 Satananda Burla <sburla@...vell.com>
Subject: Re: [PATCH net v4 1/7] octeon_ep: Add checks to fix double free
 crashes

On 13/11/2024 11:13, Shinas Rasheed wrote:
> From: Vimlesh Kumar <vimleshk@...vell.com>
> 
> Add required checks to avoid double free. Crashes were
> observed due to the same on reset scenarios, when reset
> was tried multiple times, and the first reset had torn
> down resources already.

I'm looking at the whole series and it feels like we have to deal
with the root cause rather than add protective code left and right.

The driver may potentially have some locks missing which will cause
missing resources, and to fix the root cause these locks have to be
added. WDYT?