linux-kernel - Re: [PATCH net-next 1/7] ynl: support attr-cnt-name attribute in legacy definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzU4lNqhu43Wagjh@mini-arch>
Date: Wed, 13 Nov 2024 15:39:00 -0800
From: Stanislav Fomichev <stfomichev@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Stanislav Fomichev <sdf@...ichev.me>, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	linux-kernel@...r.kernel.org, horms@...nel.org,
	donald.hunter@...il.com, andrew+netdev@...n.ch,
	kory.maincent@...tlin.com, nicolas.dichtel@...nd.com
Subject: Re: [PATCH net-next 1/7] ynl: support attr-cnt-name attribute in
 legacy definitions

On 11/13, Jakub Kicinski wrote:
> On Wed, 13 Nov 2024 10:10:17 -0800 Stanislav Fomichev wrote:
> > This is similar to existing attr-cnt-name in the attributes
> > to allow changing the name of the 'count' enum entry.
> 
> why attr- ? we have similar attrs for cmd and we use cmd- as a prefix,
> so I'd just use enum-

Mostly because I don't have too much state on the spec side :-[ Did a
copy-paste from the attributes... Will switch to enum.
 
> I'd put it into genetlink-c level (you'll have to copy/paste into two
> specs), all the non-functional stuff related to C code gen is in the
> genetlink-c spec
> 
> Please double check Documentation doesn't need extending

Will do, thanks for the pointers! The doc is definitely missing.