linux-kernel - Re: [PATCH v3 1/1] ufs: ufs_sb_private_info: remove unused s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241113000004.GE3387508@ZenIV>
Date: Wed, 13 Nov 2024 00:00:04 +0000
From: Al Viro <viro@...iv.linux.org.uk>
To: Agathe Porte <agathe.porte@...onical.com>
Cc: linux-kernel@...r.kernel.org, Jeff Johnson <quic_jjohnson@...cinc.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v3 1/1] ufs: ufs_sb_private_info: remove unused
 s_{2,3}apb fields

On Tue, Nov 12, 2024 at 01:18:25PM +0100, Agathe Porte wrote:
> These two fields are populated and stored as a "frequently used value"
> in ufs_fill_super, but are not used afterwards in the driver.
> 
> Moreover, one of the shifts triggers UBSAN: shift-out-of-bounds when
> apbshift is 12 because 12 * 3 = 36 and 1 << 36 does not fit in the 32
> bit integer used to store the value.
> 
> Closes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2087853
> Signed-off-by: Agathe Porte <agathe.porte@...onical.com>

Applied to viro/vfs.git#work.ufs