linux-kernel - RE: [PATCH v15 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <506ba6eab1134f379f0cc1c52c2fd280@huawei.com>
Date: Wed, 13 Nov 2024 07:59:59 +0000
From: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@...wei.com>
To: Alex Williamson <alex.williamson@...hat.com>
CC: liulongfang <liulongfang@...wei.com>, "jgg@...dia.com" <jgg@...dia.com>,
	Jonathan Cameron <jonathan.cameron@...wei.com>, "kvm@...r.kernel.org"
	<kvm@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linuxarm@...neuler.org"
	<linuxarm@...neuler.org>
Subject: RE: [PATCH v15 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon
 migration driver



> -----Original Message-----
> From: Alex Williamson <alex.williamson@...hat.com>
> Sent: Tuesday, November 12, 2024 9:51 PM
> To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@...wei.com>
> Cc: liulongfang <liulongfang@...wei.com>; jgg@...dia.com; Jonathan
> Cameron <jonathan.cameron@...wei.com>; kvm@...r.kernel.org; linux-
> kernel@...r.kernel.org; linuxarm@...neuler.org
> Subject: Re: [PATCH v15 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon
> migration driver
> 
> On Tue, 12 Nov 2024 08:40:03 +0000
> Shameerali Kolothum Thodi <shameerali.kolothum.thodi@...wei.com>
> wrote:
> 
> > > -----Original Message-----
> > > From: liulongfang <liulongfang@...wei.com>
> > > Sent: Tuesday, November 12, 2024 7:33 AM
> > > To: alex.williamson@...hat.com; jgg@...dia.com; Shameerali Kolothum
> > > Thodi <shameerali.kolothum.thodi@...wei.com>; Jonathan Cameron
> > > <jonathan.cameron@...wei.com>
> > > Cc: kvm@...r.kernel.org; linux-kernel@...r.kernel.org;
> > > linuxarm@...neuler.org; liulongfang <liulongfang@...wei.com>
> > > Subject: [PATCH v15 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon
> > > migration driver
> > >
> > >
> > > +static void hisi_acc_vfio_debug_init(struct hisi_acc_vf_core_device
> > > *hisi_acc_vdev)
> > > +{
> > > +	struct vfio_device *vdev = &hisi_acc_vdev->core_device.vdev;
> > > +	struct hisi_acc_vf_migration_file *migf = NULL;
> > > +	struct dentry *vfio_dev_migration = NULL;
> > > +	struct dentry *vfio_hisi_acc = NULL;
> >
> > Nit, I think we can get rid of these NULL initializations.
> 
> Yup, all three are unnecessary.
> 
> > If you have time, please consider respin (sorry, missed this in earlier
> reviews.)
> 
> If that's the only comment, I can fix that on commit if you want to add
> an ack/review conditional on that change.  Thanks,

Thanks Alex.

With the above nits addressed,

Reviewed-by: Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>

Shameer