linux-kernel - Re: [PATCH 1/2] drm/amdgpu: set passthrough mode for xen pvh/hvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BL1PR12MB5849050822DACADF5273CD26E75A2@BL1PR12MB5849.namprd12.prod.outlook.com>
Date: Wed, 13 Nov 2024 08:13:42 +0000
From: "Chen, Jiqian" <Jiqian.Chen@....com>
To: "Deucher, Alexander" <Alexander.Deucher@....com>, "Koenig, Christian"
	<Christian.Koenig@....com>, "Pan, Xinhui" <Xinhui.Pan@....com>
CC: "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Pelloux-Prayer, Pierre-Eric" <Pierre-eric.Pelloux-prayer@....com>, "Huang,
 Ray" <Ray.Huang@....com>, "Chen, Jiqian" <Jiqian.Chen@....com>
Subject: Re: [PATCH 1/2] drm/amdgpu: set passthrough mode for xen pvh/hvm

Hi,

On 2024/11/5 14:05, Jiqian Chen wrote:
> From: Huang Rui <ray.huang@....com>
> 
> There is an second stage translation between the guest machine address
> and host machine address in Xen PVH/HVM. The PCI bar address in the xen
> guest kernel are not translated at the second stage on Xen PVH/HVM, so
> it's not the real physical address that hardware would like to know, so
> we need to set passthrough mode for Xen PVH/HVM as well.
> 
> Signed-off-by: Huang Rui <ray.huang@....com>
> Signed-off-by: Jiqian Chen <Jiqian.Chen@....com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> index b6397d3229e1..0836fb77b263 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> @@ -764,7 +764,8 @@ void amdgpu_detect_virtualization(struct amdgpu_device *adev)
>  
>  	if (!reg) {
>  		/* passthrough mode exclus sriov mod */
> -		if (is_virtual_machine() && !xen_initial_domain())
> +		if (is_virtual_machine() &&
> +		    !(xen_initial_domain() && xen_pv_domain()))
>  			adev->virt.caps |= AMDGPU_PASSTHROUGH_MODE;
>  	}
>  

Do you have any comments on this patch?

-- 
Best regards,
Jiqian Chen.