linux-kernel - Re: [PATCH v13 2/8] mtd: rawnand: qcom: cleanup qcom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bjyjsds3.fsf@bootlin.com>
Date: Wed, 13 Nov 2024 10:07:08 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Md Sadre Alam <quic_mdalam@...cinc.com>
Cc: <broonie@...nel.org>,  <robh@...nel.org>,  <krzk+dt@...nel.org>,
  <conor+dt@...nel.org>,  <andersson@...nel.org>,
  <konradybcio@...nel.org>,  <richard@....at>,  <vigneshr@...com>,
  <manivannan.sadhasivam@...aro.org>,  <linux-arm-msm@...r.kernel.org>,
  <linux-spi@...r.kernel.org>,  <devicetree@...r.kernel.org>,
  <linux-kernel@...r.kernel.org>,  <linux-mtd@...ts.infradead.org>,
  <quic_srichara@...cinc.com>,  <quic_varada@...cinc.com>
Subject: Re: [PATCH v13 2/8] mtd: rawnand: qcom: cleanup qcom_nandc driver

Hello,

On 12/11/2024 at 17:45:07 +0530, Md Sadre Alam <quic_mdalam@...cinc.com> wrote:

> On 11/12/2024 12:00 AM, Miquel Raynal wrote:
>> On 30/10/2024 at 17:49:13 +0530, Md Sadre Alam <quic_mdalam@...cinc.com> wrote:
>> 
>>> cleanup qcom_nandc driver as below
>> Perform a global cleanup of the Qualcomm NAND controller driver with
>> the
>> following improvements:
> Ok
>>>
>>> - Remove register value indirection api
>> API
> Ok
>> 
>>>
>>> - Remove set_reg() api
>> API
> Ok
>> 
>>>
>>> - Convert read_loc_first & read_loc_last macro to function
>> functions
> Ok
>> 
>>>
>>> - Renamed multiple variables
>> Rename
> Ok

In general when the main answer is "okay", you can probably just say a
sentence like "thanks for the comments I'll take them into account",
without answering to each and every comment. This way, it will be easier
for me to catch if you have further remarks.


Thanks,
Miquèl