linux-kernel - Re: [PATCH 3/3] tty: ldsic: fix tty_ldisc_autoload sysctl's proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9bb4de26-9053-4abd-a319-3e4361784ecb@kernel.org>
Date: Wed, 13 Nov 2024 10:08:43 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: nicolas.bouchinet@...p-os.org, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org, linux-fsdevel@...r.kernel.org
Cc: Nicolas Bouchinet <nicolas.bouchinet@....gouv.fr>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Alexander Viro <viro@...iv.linux.org.uk>,
 Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
 Luis Chamberlain <mcgrof@...nel.org>, Kees Cook <kees@...nel.org>,
 Joel Granados <j.granados@...sung.com>, Neil Horman <nhorman@...driver.com>,
 Andrew Morton <akpm@...ux-foundation.org>, Lin Feng <linf@...gsu.com>,
 Theodore Ts'o <tytso@....edu>
Subject: Re: [PATCH 3/3] tty: ldsic: fix tty_ldisc_autoload sysctl's
 proc_handler

On 12. 11. 24, 14:13, nicolas.bouchinet@...p-os.org wrote:
> From: Nicolas Bouchinet <nicolas.bouchinet@....gouv.fr>
> 
> Commit 7c0cca7c847e ("tty: ldisc: add sysctl to prevent autoloading of
> ldiscs") introduces the tty_ldisc_autoload sysctl with the wrong
> proc_handler. .extra1 and .extra2 parameters are set to avoid other values
> thant SYSCTL_ZERO or SYSCTL_ONE to be set but proc_dointvec do not uses
> them.
> 
> This commit fixes this by using proc_dointvec_minmax instead of
> proc_dointvec.
> 
> Fixes: 7c0cca7c847e ("tty: ldisc: add sysctl to prevent autoloading of ldiscs")
> Signed-off-by: Nicolas Bouchinet <nicolas.bouchinet@....gouv.fr>

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

I hope noone managed to store 2+ to that sysctl yet...

thanks,
-- 
js
suse labs