linux-kernel - Re: [PATCH v3 1/1] x86/fred: Clear WFE in missing-ENDBRANCH #CPs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzR3s78NZDIi1Rxh@gmail.com>
Date: Wed, 13 Nov 2024 10:56:03 +0100
From: Ingo Molnar <mingo@...nel.org>
To: "Xin Li (Intel)" <xin@...or.com>
Cc: linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com,
	bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org,
	hpa@...or.com, peterz@...radead.org, andrew.cooper3@...rix.com
Subject: Re: [PATCH v3 1/1] x86/fred: Clear WFE in missing-ENDBRANCH #CPs


* Xin Li (Intel) <xin@...or.com> wrote:

> +/*
> + * By definition, all missing-ENDBRANCH #CPs are a result of WFE && !ENDBR.
> + *
> + * For the kernel IBT no ENDBR selftest where #CPs are deliberately triggerred,

s/triggerred
 /triggered

> +static void ibt_clear_fred_wfe(struct pt_regs *regs)
> +{
> +	/*
> +	 * No need to do any FRED checks.
> +	 *
> +	 * For IDT event delivery, the high-order 48 bits of CS are pushed
> +	 * as 0s into stack, and later IRET ignores these bits.

s/into stack
 /into the stack

Thanks,

	Ingo