linux-kernel - Re: [PATCH] mac802154: add a check for slave data list before delete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y11npfhj.fsf@bootlin.com>
Date: Wed, 13 Nov 2024 11:58:32 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Dmitry Antipov <dmantipov@...dex.ru>
Cc: Lizhi Xu <lizhi.xu@...driver.com>,  alex.aring@...il.com,
  davem@...emloft.net,  edumazet@...gle.com,  horms@...nel.org,
  kuba@...nel.org,  linux-kernel@...r.kernel.org,
  linux-usb@...r.kernel.org,  linux-wpan@...r.kernel.org,
  netdev@...r.kernel.org,  pabeni@...hat.com,  stefan@...enfreihafen.org,
  syzbot+985f827280dc3a6e7e92@...kaller.appspotmail.com,
  syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH] mac802154: add a check for slave data list before delete

On 13/11/2024 at 13:29:55 +03, Dmitry Antipov <dmantipov@...dex.ru> wrote:

> On 11/12/24 4:41 PM, Lizhi Xu wrote:
>
>>   	mutex_lock(&sdata->local->iflist_mtx);
>> +	if (list_empty(&sdata->local->interfaces)) {
>> +		mutex_unlock(&sdata->local->iflist_mtx);
>> +		return;
>> +	}
>>   	list_del_rcu(&sdata->list);
>>   	mutex_unlock(&sdata->local->iflist_mtx);
>
> Note https://syzkaller.appspot.com/text?tag=ReproC&x=12a9f740580000 makes an
> attempt to connect the only device. How this is expected to work if there are
> more than one device?

Isn't sdata already specific enough? What do you mean by "device"?

Thanks,
Miquèl