linux-kernel - Re: [PATCH net v2 2/2] selftests: drv-net: rss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <d5b21f01-0f19-4580-bb7a-829d46ee7dcb@app.fastmail.com>
Date: Tue, 12 Nov 2024 17:51:50 -0800
From: "Daniel Xu" <dxu@...uu.xyz>
To: "Edward Cree" <ecree.xilinx@...il.com>, "Paolo Abeni" <pabeni@...hat.com>,
 "Eric Dumazet" <edumazet@...gle.com>, "David Miller" <davem@...emloft.net>,
 "Shuah Khan" <shuah@...nel.org>, andrew+netdev@...n.ch,
 "Jakub Kicinski" <kuba@...nel.org>,
 "Michael Chan" <michael.chan@...adcom.com>,
 "Martin KaFai Lau" <martin.lau@...ux.dev>,
 "Pavan Chebbi" <pavan.chebbi@...adcom.com>
Cc: netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, "Kernel Team" <kernel-team@...a.com>
Subject: Re: [PATCH net v2 2/2] selftests: drv-net: rss_ctx: Add test for ntuple rule

Hi Ed,

On Tue, Nov 12, 2024, at 3:10 AM, Edward Cree wrote:
> On 12/11/2024 02:23, Daniel Xu wrote:
>> Extend the rss_ctx test suite to test that an ntuple action that
>> redirects to an RSS context contains that information in `ethtool -n`.
>> Otherwise the output from ethtool is highly deceiving. This test helps
>> ensure drivers are compliant with the API.
>> 
>> Signed-off-by: Daniel Xu <dxu@...uu.xyz>
> ...
>> +def _ntuple_rule_check(cfg, rule_id, ctx_id):
>> +    """Check that ntuple rule references RSS context ID"""
>> +    text = ethtool(f"-n {cfg.ifname} rule {rule_id}").stdout
>> +    pattern = f"RSS Context ID: {ctx_id}"
>> +    ksft_true(re.search(pattern, text, re.IGNORECASE),
>
> This won't match the output from your ethtool patch, because that
>  removes the colon.  Probably want to wait until the patch is
>  finalised and then write a regex that matches both versions.

Argh, I meant to have wildcards here. But yeah, makes sense, will wait
until the other patch is finalized.

Thanks,
Daniel