linux-kernel - Re: [PATCH] PCI: of_property: Assign PCI instead of CPU bus address to dynamic PCI nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241114164551.46664f5d@bootlin.com>
Date: Thu, 14 Nov 2024 16:45:51 +0100
From: Herve Codina <herve.codina@...tlin.com>
To: Andrea della Porta <andrea.porta@...e.com>
Cc: Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Florian Fainelli
 <florian.fainelli@...adcom.com>, Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Lorenzo Pieralisi
 <lpieralisi@...nel.org>, Krzysztof Wilczynski <kw@...ux.com>, Manivannan
 Sadhasivam <manivannan.sadhasivam@...aro.org>, Bjorn Helgaas
 <bhelgaas@...gle.com>, Linus Walleij <linus.walleij@...aro.org>, Catalin
 Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Bartosz
 Golaszewski <brgl@...ev.pl>, Derek Kiernan <derek.kiernan@....com>, Dragan
 Cvetic <dragan.cvetic@....com>, Arnd Bergmann <arnd@...db.de>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, Saravana Kannan
 <saravanak@...gle.com>, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-pci@...r.kernel.org, linux-gpio@...r.kernel.org, Masahiro Yamada
 <masahiroy@...nel.org>, Stefan Wahren <wahrenst@....net>, Luca Ceresoli
 <luca.ceresoli@...tlin.com>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, Andrew Lunn <andrew@...n.ch>,
 stable@...r.kernel.org
Subject: Re: [PATCH] PCI: of_property: Assign PCI instead of CPU bus address
 to dynamic PCI nodes

Hi Andrea,

On Thu, 14 Nov 2024 16:26:42 +0100
Andrea della Porta <andrea.porta@...e.com> wrote:

> Hi,
> 
> On 11:14 Fri 08 Nov     , Andrea della Porta wrote:
> > Hi herve,
> > 
> > On 11:09 Fri 08 Nov     , Herve Codina wrote:  
> > > Hi Andrea,
> > > 
> > > On Fri,  8 Nov 2024 10:42:56 +0100
> > > Andrea della Porta <andrea.porta@...e.com> wrote:
> > >   
> > > > When populating "ranges" property for a PCI bridge or endpoint,
> > > > of_pci_prop_ranges() incorrectly use the CPU bus address of the resource.
> > > > In such PCI nodes, the window should instead be in PCI address space. Call
> > > > pci_bus_address() on the resource in order to obtain the PCI bus
> > > > address.
> > > > 
> > > > Fixes: 407d1a51921e ("PCI: Create device tree node for bridge")
> > > > Cc: stable@...r.kernel.org
> > > > Signed-off-by: Andrea della Porta <andrea.porta@...e.com>
> > > > Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
> > > > Tested-by: Herve Codina <herve.codina@...tlin.com>
> > > > ---
> > > > This patch, originally preparatory for a bigger patchset (see [1]), has
> > > > been splitted in a standalone one for better management and because it
> > > > contains a bugfix which is probably of interest to stable branch.  
> > > 
> > > Nothing to say for the patch itself.
> > > 
> > > Just here, you mentioned "see [1]" but you didn't provide the link.
> > > 
> > > IMHO, this is not blocking for applying the patch but, just for other people
> > > looking at this email in the mailing list, can you reply providing the link?  
> > 
> > Thanks for pointing that out, sorry about that. Here it is:
> > 
> > [1] - https://lore.kernel.org/all/f6b445b764312fd8ab96745fe4e97fb22f91ae4c.1730123575.git.andrea.porta@suse.com/  
> 
> Do I have to resubmit the patch with the referenced url fixed or is it
> ok as it is?

This reference is after the '---' marker line and so will not be present in
the changelog once the patch is applied.

For this reason, I don't think you have to resubmit the patch.

If you need to resubmit the patch for any other reasons (resent because
the patch was applied, modification needed, ...) resubmit it with the
referenced url fixed.

Best regards,
Hervé