linux-kernel - Re: [PATCH v6 11/11] printk: Purge default_console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzYnf7aJK_vyHjCK@pathway.suse.cz>
Date: Thu, 14 Nov 2024 17:38:23 +0100
From: Petr Mladek <pmladek@...e.com>
To: Chris Down <chris@...isdown.name>
Cc: linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	John Ogness <john.ogness@...utronix.de>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Tony Lindgren <tony.lindgren@...ux.intel.com>, kernel-team@...com
Subject: Re: [PATCH v6 11/11] printk: Purge default_console_loglevel

On Mon 2024-10-28 16:46:01, Chris Down wrote:
> default_console_loglevel (then DEFAULT_LOGLEVEL) was created in Linux
> 0.99.13 (September 1993) to power what we now call
> SYSLOG_ACTION_CONSOLE_{ON,OFF}. It was originally hardcoded to 7.
> 
> In Linux 2.3.12 (March 1997), Chris Horn made it configurable by sysctl
> through kernel.printk.
> 
> Its demise came about in July 2009 in commit 1aaad49e856c ("printk:
> Restore previous console_loglevel when re-enabling logging"), which
> replaces default_console_loglevel with the previously used
> console_loglevel. However, the documentation was never updated, and we
> still kept on telling users that this sets the default value for
> console_loglevel, even though this hasn't been true for over 15 years.
> 
> Purge both the documentation and all remaining references to
> default_console_loglevel. It will still be initialised in the sysctl
> array.
> 
> Signed-off-by: Chris Down <chris@...isdown.name>

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr