linux-kernel - Re: [PATCH] mailbox: imx: Modify the incorrect format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzYoWFVhfNnAcAmy@lizhi-Precision-Tower-5810>
Date: Thu, 14 Nov 2024 11:42:00 -0500
From: Frank Li <Frank.li@....com>
To: zhangjiao2 <zhangjiao2@...s.chinamobile.com>
Cc: jassisinghbrar@...il.com, shawnguo@...nel.org, s.hauer@...gutronix.de,
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] mailbox: imx: Modify the incorrect format specifier

On Thu, Nov 14, 2024 at 01:59:26PM +0800, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@...s.chinamobile.com>
>
> The format specifier of "unsigned int" in snprintf()
> should be "%u", not "%i".

Replace %i with %u in snprintf() because it is "unsigned int".

Reviewed-by: Frank Li <Frank.Li@....com>

>
> Signed-off-by: zhang jiao <zhangjiao2@...s.chinamobile.com>
> ---
>  drivers/mailbox/imx-mailbox.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> index f815dab3be50..3fe51b2de89e 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -782,7 +782,7 @@ static int imx_mu_init_generic(struct imx_mu_priv *priv)
>  		cp->chan = &priv->mbox_chans[i];
>  		priv->mbox_chans[i].con_priv = cp;
>  		snprintf(cp->irq_desc, sizeof(cp->irq_desc),
> -			 "%s[%i-%i]", dev_name(priv->dev), cp->type, cp->idx);
> +			 "%s[%i-%u]", dev_name(priv->dev), cp->type, cp->idx);
>  	}
>
>  	priv->mbox.num_chans = IMX_MU_CHANS;
> @@ -819,7 +819,7 @@ static int imx_mu_init_specific(struct imx_mu_priv *priv)
>  		cp->chan = &priv->mbox_chans[i];
>  		priv->mbox_chans[i].con_priv = cp;
>  		snprintf(cp->irq_desc, sizeof(cp->irq_desc),
> -			 "%s[%i-%i]", dev_name(priv->dev), cp->type, cp->idx);
> +			 "%s[%i-%u]", dev_name(priv->dev), cp->type, cp->idx);
>  	}
>
>  	priv->mbox.num_chans = num_chans;
> --
> 2.33.0
>
>
>