linux-kernel - 回覆: [net-next 3/3] net: ftgmac100: Support for AST2700

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB51343BB70CD66E547D637FE79D5B2@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Thu, 14 Nov 2024 02:22:16 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Simon Horman <horms@...nel.org>
CC: "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, "ratbert@...aday-tech.com"
	<ratbert@...aday-tech.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject:
 回覆: [net-next 3/3] net: ftgmac100: Support for AST2700

Hi Simon,

Thank you for your reply.

> > @@ -1965,16 +1980,27 @@ static int ftgmac100_probe(struct
> platform_device *pdev)
> >  			dev_err(priv->dev, "MII probe failed!\n");
> >  			goto err_ncsi_dev;
> >  		}
> > -
> >  	}
> >
> >  	if (priv->is_aspeed) {
> > +		struct reset_control *rst;
> > +
> >  		err = ftgmac100_setup_clk(priv);
> >  		if (err)
> >  			goto err_phy_connect;
> >
> > -		/* Disable ast2600 problematic HW arbitration */
> > -		if (of_device_is_compatible(np, "aspeed,ast2600-mac"))
> > +		rst = devm_reset_control_get_optional(priv->dev, NULL);
> > +		if (IS_ERR(rst))
> 
> Hi Jacky,
> 
> Should err be set to ERR_PTR(rst) here so that value is returned by the
> function?

Yes. I will add checking the return value in the next version.

> 
> > +			goto err_register_netdev;
> > +
> > +		priv->rst = rst;
> > +		err = reset_control_assert(priv->rst);
> > +		mdelay(10);
> > +		err = reset_control_deassert(priv->rst);
> > +
> > +		/* Disable some aspeed platform problematic HW arbitration */
> > +		if (of_device_is_compatible(np, "aspeed,ast2600-mac") ||
> > +		    of_device_is_compatible(np, "aspeed,ast2700-mac"))
> >  			iowrite32(FTGMAC100_TM_DEFAULT,
> >  				  priv->base + FTGMAC100_OFFSET_TM);
> >  	}

Thanks,
Jacky