linux-kernel - Re: [PATCH 1/2] scripts/min-tool-version.sh: Raise minimum clang version to 19.1.0 for s390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241114172535.GB1956005@thelio-3990X>
Date: Thu, 14 Nov 2024 10:25:35 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Heiko Carstens <hca@...ux.ibm.com>
Cc: Nick Desaulniers <ndesaulniers@...gle.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
	Sven Schnelle <svens@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>
Subject: Re: [PATCH 1/2] scripts/min-tool-version.sh: Raise minimum clang
 version to 19.1.0 for s390

On Thu, Nov 14, 2024 at 06:05:24PM +0100, Heiko Carstens wrote:
> On Wed, Nov 13, 2024 at 11:21:09AM -0700, Nathan Chancellor wrote:
> > On Wed, Nov 13, 2024 at 04:40:12PM +0100, Heiko Carstens wrote:
> > > Raise minimum clang version to 19.1.0 for s390 so that various inline
> > > assembly format flags can be used. The missing format flags were
> > > implemented with llvm-project commit 9c75a981554d ("[SystemZ] Implement A,
> > > O and R inline assembly format flags (#80685)").
> > > 
> > > Signed-off-by: Heiko Carstens <hca@...ux.ibm.com>
> > 
> > Oof, this is quite new but now that kernel.org has LLVM binaries
> > available, I do not think this is an unreasonable ask, especially if it
> > makes your life easier with code maintenance.
> 
> Thanks for your feedback! I read this as "is nearly unreasonable" :)

Yeah, that is probably a fair way to put it :)

> Even though you acked this, I guess I will drop this for now and
> maybe address this a few clang versions later.

Yes, I think waiting until that LLVM change has had some time to
actually make it into the hands of users would be good if it is not too
much of a burden. However, if you start writing new kernel code that depends on
these format flags, it may be reasonable to revisit this series at that
point for ease of maintenance on your end.

Cheers,
Nathan