linux-kernel - Re: syslog warning: was: Re: [PATCH v6 04/11] printk: Support toggling per-console loglevel via syslog() and cmdline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzZHNIL6o0Ep1vfA@chrisdown.name>
Date: Thu, 14 Nov 2024 13:53:40 -0500
From: Chris Down <chris@...isdown.name>
To: Petr Mladek <pmladek@...e.com>
Cc: linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	John Ogness <john.ogness@...utronix.de>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Tony Lindgren <tony.lindgren@...ux.intel.com>, kernel-team@...com
Subject: Re: syslog warning: was: Re: [PATCH v6 04/11] printk: Support
 toggling per-console loglevel via syslog() and cmdline

Petr Mladek writes:
>I see this warning during every boot because rsyslogd() modifies the
>global loglevel.
>
>[...]
>
>I am not sure if we have already discussed this in the past.
>But I would prefer the compromise after all.

I initially implemented that way until v4, but during the v3 review, as I 
understood it you recommended changing it to use !ignore_per_console_loglevel 
based on the assumption that SYSLOG_ACTION_CONSOLE_{ON,OFF} wasn't widely used. 
Maybe I misunderstood what was intended?

Happy to revert to the previous approach with warn_on_local_loglevel(), just 
let me know :-)