[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA+D8AP=cdyvhtzDib8-T5GuHU9pXhPVgdomTQj8R=8CCFr5HQ@mail.gmail.com>
Date: Thu, 14 Nov 2024 10:37:44 +0800
From: Shengjiu Wang <shengjiu.wang@...il.com>
To: Peng Fan <peng.fan@....com>
Cc: "S.J. Wang" <shengjiu.wang@....com>, "abelvesa@...nel.org" <abelvesa@...nel.org>,
"mturquette@...libre.com" <mturquette@...libre.com>, "sboyd@...nel.org" <sboyd@...nel.org>,
"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>, "shawnguo@...nel.org" <shawnguo@...nel.org>,
"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "kernel@...gutronix.de" <kernel@...gutronix.de>,
"festevam@...il.com" <festevam@...il.com>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] arm64: dts: imx93: Use IMX93_CLK_SPDIF_IPG as
SPDIF IPG clock
On Mon, Nov 11, 2024 at 11:11 AM Peng Fan <peng.fan@....com> wrote:
>
> > Subject: [PATCH v2 3/3] arm64: dts: imx93: Use IMX93_CLK_SPDIF_IPG
> > as SPDIF IPG clock
> >
>
> This patch has a fix tag, but the other two not have. So the other two
> will not be backported and cause issue.
>
> So use fixes for all or drop fixes for all.
>
Should I add the one same fixes tag to all 3 commits?
Best regards
Shengjiu Wang
> Regards,
> Peng.
>
> > IMX93_CLK_BUS_WAKEUP is not accurate IPG clock, which missed the
> > clock gate part.
> >
> > IMX93_CLK_SPDIF_IPG is the correct clock.
> >
> > Fixes: 1c4a4f7362fd ("arm64: dts: imx93: Add audio device nodes")
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> > Reviewed-by: Frank Li <Frank.Li@....com>
> > ---
> > arch/arm64/boot/dts/freescale/imx93.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> > b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > index 688488de8cd2..56766fdb0b1e 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > @@ -925,7 +925,7 @@ xcvr: xcvr@...80000 {
> > reg-names = "ram", "regs", "rxfifo",
> > "txfifo";
> > interrupts = <GIC_SPI 203
> > IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 204
> > IRQ_TYPE_LEVEL_HIGH>;
> > - clocks = <&clk
> > IMX93_CLK_BUS_WAKEUP>,
> > + clocks = <&clk
> > IMX93_CLK_SPDIF_IPG>,
> > <&clk
> > IMX93_CLK_SPDIF_GATE>,
> > <&clk IMX93_CLK_DUMMY>,
> > <&clk
> > IMX93_CLK_AUD_XCVR_GATE>;
> > --
> > 2.34.1
>
Powered by blists - more mailing lists