linux-kernel - Re: [PATCH net 2/2] selftests/rtnetlink.sh: add mngtempaddr test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241113184312.7a33a83d@kernel.org>
Date: Wed, 13 Nov 2024 18:43:12 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, David
 Ahern <dsahern@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Shuah Khan
 <shuah@...nel.org>, Sam Edwards <cfsworks@...il.com>,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net 2/2] selftests/rtnetlink.sh: add mngtempaddr test

On Thu, 14 Nov 2024 02:00:01 +0000 Hangbin Liu wrote:
> > # [+300.25] tempaddr not deleted for 2001:db8::1
> > # [+0.16] tempaddr not deleted for 2003:db8::1
> > # [+0.07] FAIL: mngtmpaddr add/remove incorrect
> > not ok 1 selftests: net: rtnetlink.sh # exit=1  
> 
> Is this tested with patched kernel or unpatched kernel. On my local side I got
> 
> # ./rtnetlink.sh -t kci_test_mngtmpaddr
> PASS: mngtmpaddr add/remove correctly

I believe you that you run the test before sending.
But if it doesn't pass in CI we can't merge this.
Just a shot in the dark but does it also pass without the -t ?