linux-kernel - Re: [PATCH] clk:sophgo:clk-cv18xx-pll: fix unitialized u32 variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZzZXxxSghLGy_mZf@desktop>
Date: Thu, 14 Nov 2024 12:04:23 -0800
From: "Ragavendra B.N." <ragavendra.bn@...il.com>
To: Chen Wang <unicorn_wang@...look.com>, mturquette@...libre.com,
	sboyd@...nel.org, inochiama@...look.com, ragavendra.bn@...il.com
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk:sophgo:clk-cv18xx-pll: fix unitialized u32 variable

On Thu, Nov 14, 2024 at 07:36:21AM +0800, Chen Wang wrote:
> Hi, Ragavendra,
> 
> This patch should be dropped, right? I see a new patch https://lore.kernel.org/linux-clk/20241113184617.3745423-1-ragavendra.bn@gmail.com/
> should have covered this.
> 
> Suggest you reply this patch email and declare the dropping to avoid
> confusion.
> 
> On 2024/11/13 10:02, Ragavendra wrote:
> > Initializing the val variable of type u32 as it was not initialized.
> > 
> > Fixes: 80fd61ec4612 ("clk: sophgo: Add clock support for CV1800 SoC")
> > Signed-off-by: Ragavendra Nagraj <ragavendra.bn@...il.com>
> > ---
> >   drivers/clk/sophgo/clk-cv18xx-pll.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clk/sophgo/clk-cv18xx-pll.c b/drivers/clk/sophgo/clk-cv18xx-pll.c
> > index 29e24098bf5f..04a0419cab4e 100644
> > --- a/drivers/clk/sophgo/clk-cv18xx-pll.c
> > +++ b/drivers/clk/sophgo/clk-cv18xx-pll.c
> > @@ -87,7 +87,7 @@ static int ipll_find_rate(const struct cv1800_clk_pll_limit *limit,
> >   static int ipll_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
> >   {
> > -	u32 val;
> > +	u32 val = 0;
> >   	struct cv1800_clk_pll *pll = hw_to_cv1800_clk_pll(hw);
> >   	return ipll_find_rate(pll->pll_limit, req->best_parent_rate,
hi Chen,
  You are correct, please drop this patch email.

--
Yours sincerely,
Ragavendra N