linux-kernel - Re: [PATCH] drm/panel-edp: Add KDB KD116N2130B12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=V_jYygpcCcU0H7UOL2AY5vbg-y0UpJczwWBKyc4+L8kA@mail.gmail.com>
Date: Thu, 14 Nov 2024 13:01:18 -0800
From: Doug Anderson <dianders@...omium.org>
To: Langyan Ye <yelangyan@...qin.corp-partner.google.com>
Cc: thierry.reding@...il.com, sam@...nborg.org, airlied@...il.com, 
	daniel@...ll.ch, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel-edp: Add KDB KD116N2130B12

Hi,

On Wed, Nov 13, 2024 at 1:00 AM Langyan Ye
<yelangyan@...qin.corp-partner.google.com> wrote:
>
> Add support for the KDB KD116N2130B12, pleace the EDID here for
> subsequent reference.
> 00 ff ff ff ff ff ff 00 2c 82 07 17 00 00 00 00
> 1c 21 01 04 95 1a 0e 78 0a 63 25 99 5b 5d 96 26
> 18 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 87 1b 56 88 50 00 0e 30 28 20
> 55 00 00 90 10 00 00 18 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fe
> 00 4b 44 31 31 36 4e 32 31 33 30 42 31 32 00 17
>
> Signed-off-by: Langyan Ye <yelangyan@...qin.corp-partner.google.com>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index 012dfbcb9475..5355acd52f0b 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1978,6 +1978,12 @@ static const struct panel_delay delay_200_500_e50_po2e200 = {
>         .powered_on_to_enable = 200,
>  };
>
> +static const struct panel_delay delay_200_150_e50 = {
> +       .hpd_absent = 200,
> +       .unprepare = 150,
> +       .enable = 50,
> +};
> +
>  #define EDP_PANEL_ENTRY(vend_chr_0, vend_chr_1, vend_chr_2, product_id, _delay, _name) \
>  { \
>         .ident = { \
> @@ -2134,6 +2140,7 @@ static const struct edp_panel_entry edp_panels[] = {
>         EDP_PANEL_ENTRY('K', 'D', 'B', 0x0624, &kingdisplay_kd116n21_30nv_a010.delay, "116N21-30NV-A010"),
>         EDP_PANEL_ENTRY('K', 'D', 'B', 0x1118, &delay_200_500_e50, "KD116N29-30NK-A005"),
>         EDP_PANEL_ENTRY('K', 'D', 'B', 0x1120, &delay_200_500_e80_d50, "116N29-30NK-C007"),
> +       EDP_PANEL_ENTRY('K', 'D', 'B', 0x1707, &delay_200_150_e50, "KD116N2130B12"),

In the future, please post patches against upstream Linux. For
panel-edp.c, you'd ideally want to post against
drm-misc/drm-misc-next. Specifically, in upstream the entry right
before your new one should have been "'K', 'D', 'B', 0x1212", not
"'K', 'D', 'B', 0x1120". That's been upstream for the last 6 months...

In any case, I'll resolve the conflict this time since it's trivial.

Reviewed-by: Douglas Anderson <dianders@...omium.org>

Pushed to drm-misc-next:

[1/1] drm/panel-edp: Add KDB KD116N2130B12
      commit: ae4a812a64dad3fd4f7bbcd7af215cb68af8cf8c

-Doug