linux-kernel - RE: [PATCH v2 02/22] HID: intel-thc-hid: Add basic THC driver skeleton

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR11MB60988FF5961FDCEEF0A9F6E1F45B2@IA1PR11MB6098.namprd11.prod.outlook.com>
Date: Thu, 14 Nov 2024 05:56:24 +0000
From: "Xu, Even" <even.xu@...el.com>
To: Randy Dunlap <rdunlap@...radead.org>, "jikos@...nel.org"
	<jikos@...nel.org>, "bentiss@...nel.org" <bentiss@...nel.org>,
	"corbet@....net" <corbet@....net>, "bagasdotme@...il.com"
	<bagasdotme@...il.com>, "Aaron, Ma" <aaron.ma@...onical.com>
CC: "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "Sun, Xinpeng"
	<xinpeng.sun@...el.com>, "Zhang, Rui1" <rui1.zhang@...el.com>, "Srinivas
 Pandruvada" <srinivas.pandruvada@...ux.intel.com>
Subject: RE: [PATCH v2 02/22] HID: intel-thc-hid: Add basic THC driver
 skeleton



> -----Original Message-----
> From: Randy Dunlap <rdunlap@...radead.org>
> Sent: Thursday, November 14, 2024 1:42 PM
> To: Xu, Even <even.xu@...el.com>; jikos@...nel.org; bentiss@...nel.org;
> corbet@....net; bagasdotme@...il.com; Aaron, Ma
> <aaron.ma@...onical.com>
> Cc: linux-input@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> doc@...r.kernel.org; Sun, Xinpeng <xinpeng.sun@...el.com>; Zhang, Rui1
> <rui1.zhang@...el.com>; Srinivas Pandruvada
> <srinivas.pandruvada@...ux.intel.com>
> Subject: Re: [PATCH v2 02/22] HID: intel-thc-hid: Add basic THC driver skeleton
> 
> 
> 
> On 11/13/24 9:33 PM, Even Xu wrote:
> > diff --git a/drivers/hid/intel-thc-hid/Kconfig b/drivers/hid/intel-thc-hid/Kconfig
> > new file mode 100644
> > index 000000000000..e7e8201287f8
> > --- /dev/null
> > +++ b/drivers/hid/intel-thc-hid/Kconfig
> > @@ -0,0 +1,20 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +# Copyright (c) 2024, Intel Corporation.
> > +
> > +menu "Intel THC HID Support"
> > +	depends on X86_64 && PCI
> > +
> > +config INTEL_THC_HID
> > +	tristate "Intel Touch Host Controller"
> > +	select HID
> > +	help
> > +	  THC (Touch Host Controller) is the name of the IP block in PCH that
> > +	  interface with Touch Devices (ex: touchscreen, touchpad etc.). It
> 
> 	  interfaces                   (e.g.: touchscreen, touchpad, etc.). It

Will fix it in next version.

> 
> 
> > +	  is comprised of 3 key functional blocks: A natively half-duplex
> > +	  Quad I/O capable SPI master; A low latency I2C interface to support
> 
> 	                               a low

Will fix it.

> 
> > +	  HIDI2C compliant devices; A HW sequencer with RW DMA capability to
> 
> 	                          ; and a HW
> though I prefer to spell out              hardware      Read/Write

Agree, will fix it, thanks!

> 
> > +	  system memory.
> > +
> > +	  Say Y/M here if you want to support Intel THC. If unsure, say N.
> > +
> > +endmenu
> 
> --
> ~Randy

Thanks for the comments!

Best Regards,
Even Xu