linux-kernel - Re: [PATCH v3 1/3] dt-bindings: thermal: Add support for Airoha EN7581 thermal sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80444a81-381b-4a30-b573-dcaf0c06f326@linaro.org>
Date: Thu, 14 Nov 2024 08:56:15 +0100
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Zhang Rui <rui.zhang@...el.com>,
 Lukasz Luba <lukasz.luba@....com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Lorenzo Bianconi <lorenzo@...nel.org>,
 upstream@...oha.com
Subject: Re: [PATCH v3 1/3] dt-bindings: thermal: Add support for Airoha
 EN7581 thermal sensor

On 13/11/2024 21:19, Christian Marangi wrote:
> On Wed, Nov 13, 2024 at 07:18:04PM +0100, Daniel Lezcano wrote:
>>
>> Hi Ansuel,
>>
>> On 13/11/2024 16:56, Christian Marangi wrote:
>>> On Fri, Oct 18, 2024 at 12:48:04PM +0200, Christian Marangi wrote:
>>>> Add support for Airoha EN7581 thermal sensor and monitor. This is a
>>>> simple sensor for the CPU or SoC Package that provide thermal sensor and
>>>> trip point for hot low and critical condition to fire interrupt and
>>>> react on the abnormal state.
>>>>
>>>> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
>>>> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
>>>
>>> Any news with this series? Everything wrong with the thermal core small
>>> patch?
>>
>> I understand why you are trying to achieve this but usually it is the kernel
>> which overloads the firmware description, not the opposite, no?
>>
>> Either way, we ignore the offset/slope from tzp and use a couple of private
>> variables offset/slope in the driver (iow do not call
>> thermal_zone_get_offset() thermal_zone_get_slope()). Or add the
>> thermal_zone_set_offset() and thermal_zone_set_slope() helpers.
>>
>> I would prefer the first solution as for today I can not see any DT for
>> ARM64 with the coefficients set. So may be we can consider the slope and the
>> offset as a legacy which should be removed from sysfs and the thermal zone
>> device parameters in a near future.
>>
> 
> Hi Daniel,
> 
> Having set OPs is problematic as that would diverge from what is set in
> DT that should always have priority.
> 
> Well yes my idea was trying to make use of them as currently there are
> many driver that set these values but have the slope and offset in
> thermal core always set to 0 and 1.
> 
> Thing is that reading temp with ADC is very common and in some way or
> another you always have a slope and an offset so it makese sense to
> permit to have those values preallocated instead of handling them in
> priv struct.

Right but if we look at the coefficients description, it is a bit fuzzy 
how they are used today.

> Anyway if the idea is to drop that, I will happly move those values
> handling back in the driver. Just need a confirm on that.

Yes, it is probably better to put them private to the driver while we 
sort out how to deal with the coefficients properly. Especially that we 
want to introduce thermal zones with multiple sensors support.

Thanks

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog