linux-kernel - Re: [PATCH v9 0/9] PCI: Add PCIe bandwidth controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACMJSeuU78R8W+m9s0mV9y0DLNJ=JSRHjC70FiVT36bMbimj-A@mail.gmail.com>
Date: Thu, 14 Nov 2024 09:46:29 +0100
From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
	linux-pci@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>, 
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Wilczyński <kw@...ux.com>, 
	"Maciej W . Rozycki" <macro@...am.me.uk>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, 
	Lukas Wunner <lukas@...ner.de>, Alexandru Gagniuc <mr.nuke.me@...il.com>, 
	Krishna chaitanya chundru <quic_krichai@...cinc.com>, 
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, 
	"Rafael J . Wysocki" <rafael@...nel.org>, linux-pm@...r.kernel.org, 
	Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>, linux-kernel@...r.kernel.org, 
	Daniel Lezcano <daniel.lezcano@...aro.org>, Amit Kucheria <amitk@...nel.org>, 
	Zhang Rui <rui.zhang@...el.com>, Christophe JAILLET <christophe.jaillet@...adoo.fr>, 
	Amit Pundir <amit.pundir@...aro.org>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Caleb Connolly <caleb.connolly@...aro.org>
Subject: Re: [PATCH v9 0/9] PCI: Add PCIe bandwidth controller

On Wed, 13 Nov 2024 at 22:48, Bjorn Helgaas <helgaas@...nel.org> wrote:
>
> [+cc Bart, Amit, Neil, Caleb]
>
> On Wed, Oct 23, 2024 at 05:19:04PM -0500, Bjorn Helgaas wrote:
> > On Fri, Oct 18, 2024 at 05:47:46PM +0300, Ilpo Järvinen wrote:
> > > This series adds PCIe bandwidth controller (bwctrl) and associated PCIe
> > > cooling driver to the thermal core side for limiting PCIe Link Speed
> > > due to thermal reasons. PCIe bandwidth controller is a PCI express bus
> > > port service driver. A cooling device is created for each port the
> > > service driver finds to support changing speeds.
>
> > >  drivers/pci/pcie/bwctrl.c                     | 366 ++++++++++++++++++
> > >  include/linux/pci-bwctrl.h                    |  28 ++
> > >  tools/testing/selftests/pcie_bwctrl/Makefile  |   2 +
> > >  .../pcie_bwctrl/set_pcie_cooling_state.sh     | 122 ++++++
> > >  .../selftests/pcie_bwctrl/set_pcie_speed.sh   |  67 ++++
>
> > Applied to pci/bwctrl for v6.13, thanks Ilpo (and Alexandru, for the
> > bandwidth notification interrupt support)!
>
> How attached are we to "bwctrl" and "pwrctl" as the names?
>
> I just noticed that we have "ctrl" for bandwidth control but "ctl" for
> power control, which is slightly annoying to keep straight.
>
> "ctrl" is more common in the tree:
>
>   $ find -name \*ctrl\*[ch] | wc -l
>   691
>   $ find -name \*ctl\*[ch] | wc -l
>   291
>
> so I would prefer that, although "pwrctl" is already in the tree (as
> of v6.11), so it would be more disruptive to change it than to rename
> "bwctrl".

"pwrctl" is shorter and it was the only reason for me to choose it over pwrctrl.

Bart