linux-kernel - Re: [PATCH can-next v4 2/2] can: tcan4x5x: add option for selecting nWKRQ voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nza33yftfuzjdf5fkxwwkfqink4xen7hcfnf5chcn3tmy3qnuu@xqcmqvkdfxs3>
Date: Thu, 14 Nov 2024 10:26:39 +0100
From: Sean Nyekjaer <sean@...nix.com>
To: Marc Kleine-Budde <mkl@...gutronix.de>
Cc: Vincent Mailhol <mailhol.vincent@...adoo.fr>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-can@...r.kernel.org, 
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH can-next v4 2/2] can: tcan4x5x: add option for selecting
 nWKRQ voltage

On Thu, Nov 14, 2024 at 10:19:00AM +0100, Marc Kleine-Budde wrote:
> On 14.11.2024 09:52:22, Sean Nyekjaer wrote:
> > The nWKRQ pin supports an output voltage of either the internal reference
> > voltage (3.6V) or the reference voltage of
> > the digital interface 0-6V (VIO).
> > Add the devicetree option ti,nwkrq-voltage-vio to set it to VIO.
> > 
> > If this property is omitted the reset default, the internal reference
> > voltage, is used.
> > 
> > Signed-off-by: Sean Nyekjaer <sean@...nix.com>
> > Reviewed-by: Marc Kleine-Budde <mkl@...gutronix.de>
> 
> I've given my R-b to 1/2 not 2/2 :)
> 
> Have you manually added the R-b? "b4" has an support to collect the
> trailers and add the to the patches with "b4 trailers -u".
> 
> With this change, let b4 add by R-b:
> 
> Reviewed-by: Marc Kleine-Budde <mkl@...gutronix.de>
> 
> regards,
> Marc
> 

Oh, I see my bad :) 

Actually just went thru the b4 manual and didn't see that option.

Ran the "b4 trailers -u", It added the Acked-by: in
https://lore.kernel.org/all/20241114-quirky-aquamarine-junglefowl-408784-mkl@pengutronix.de/

Thanks.
/Sean