linux-kernel - Re: [PATCH net] xfrm: replace deprecated strncpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzXS/A/LcKCCDYRp@gauss3.secunet.de>
Date: Thu, 14 Nov 2024 11:37:48 +0100
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Paolo Abeni <pabeni@...hat.com>
CC: Daniel Yang <danielyangkang@...il.com>, Herbert Xu
	<herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Simon
 Horman <horms@...nel.org>, "open list:NETWORKING [IPSEC]"
	<netdev@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] xfrm: replace deprecated strncpy with strscpy_pad

On Thu, Nov 14, 2024 at 11:34:25AM +0100, Paolo Abeni wrote:
> On 11/13/24 10:20, Daniel Yang wrote:
> > The function strncpy is deprecated since it does not guarantee the
> > destination buffer is NULL terminated. Recommended replacement is
> > strscpy. The padded version was used to remain consistent with the other
> > strscpy_pad usage in the modified function.
> > 
> > Signed-off-by: Daniel Yang <danielyangkang@...il.com>
> > ---
> >  net/xfrm/xfrm_user.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
> > index e3b8ce898..085f68e35 100644
> > --- a/net/xfrm/xfrm_user.c
> > +++ b/net/xfrm/xfrm_user.c
> > @@ -1089,7 +1089,7 @@ static int copy_to_user_auth(struct xfrm_algo_auth *auth, struct sk_buff *skb)
> >  	if (!nla)
> >  		return -EMSGSIZE;
> >  	algo = nla_data(nla);
> > -	strncpy(algo->alg_name, auth->alg_name, sizeof(algo->alg_name));
> > +	strscpy_pad(algo->alg_name, auth->alg_name, sizeof(algo->alg_name));
> >  
> >  	if (redact_secret && auth->alg_key_len)
> >  		memset(algo->alg_key, 0, (auth->alg_key_len + 7) / 8);
> 
> @Steffen, @Herbert: I think this should go via your tree despite the
> prefix tag.

I'll take it into ipsec-next.

Thanks!