linux-kernel - Re: [PATCH v2] i2c: dev: Fix memory leak when underlying adapter does not support I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZzXU2YSK56C8bqp4@shikoro>
Date: Thu, 14 Nov 2024 11:45:45 +0100
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Igor Pylypiv <ipylypiv@...gle.com>
Cc: Jean Delvare <jdelvare@...e.de>, Andi Shyti <andi.shyti@...nel.org>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] i2c: dev: Fix memory leak when underlying adapter
 does not support I2C

On Fri, Nov 08, 2024 at 12:15:42AM +0000, Igor Pylypiv wrote:
> Early return in i2cdev_ioctl_rdwr() failed to free the memory allocated
> by the caller. Move freeing the memory to the function where it has been
> allocated to prevent similar leaks in the future.
> 
> Fixes: 97ca843f6ad3 ("i2c: dev: Check for I2C_FUNC_I2C before calling i2c_transfer")
> Signed-off-by: Igor Pylypiv <ipylypiv@...gle.com>

Applied to for-next, thanks!

> +	if (data_ptrs == NULL)

I changed this to '!data_ptrs' while here because most of the file does
it like this. And checkpatch and I prefer it, too.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)