linux-kernel - Re: [PATCH v1 1/1] gpio: Move and sort Kconfig entries as suggested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzXhf2zM9IisvZhs@smile.fi.intel.com>
Date: Thu, 14 Nov 2024 13:39:43 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] gpio: Move and sort Kconfig entries as suggested

On Thu, Nov 14, 2024 at 12:15:46PM +0100, Bartosz Golaszewski wrote:
> On Thu, Nov 14, 2024 at 11:39 AM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> > On Thu, Nov 14, 2024 at 09:54:50AM +0100, Bartosz Golaszewski wrote:
> > > On Wed, Nov 13, 2024 at 6:12 PM Andy Shevchenko
> > > <andriy.shevchenko@...ux.intel.com> wrote:
> > > >
> > > > The Kconfig under drivers/gpio has a specific comment
> > > >
> > > >   put drivers in the right section, in alphabetical order
> > > >
> > > > but in time some of the entries fell unordered there.
> > > > Put an order again.
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > > > ---
> > > Could you elaborate on why you're moving drivers between categories?
> > > For instance: you moved Intel LJCA to USB drivers and I'm sure you
> > > have a reason for it (it's not clear if this actually is a USB driver,
> >
> > This one is actually clear as you see that it depends on USB_LJCS which
> > suggests that it's USB based.
> >
> > > it's not registered as such
> >
> > Neither one of the existing ones in that category, right?
> >
> 
> Well if you really want to open that can of worms...
> 
> Only gpio-mpsse is really a stand-alone USB GPIO expander. Others in
> this section are actually MFD devices and would probably better fit in
> there.
> 
> I don't have a strong opinion but we should at least be consistent.

So, as far as I can read the whole picture the categories are based on the HW
(and this is how it should be) and these what I moved _are_ true USB devices.
Linux abstraction is just a Linux abstraction.

If you want consistency, drop these categories for good, just have plain list
of the all GPIO drivers. No room for any speculations :-)

> > > ) but please expand on it in the commit message.
> >
> > Okay, I will do in v2.
> >
> > Thank you for the review!

-- 
With Best Regards,
Andy Shevchenko