linux-kernel - Re: [PATCH net v2] netfilter: ipset: add missing range check in bitmap_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZzXoYcxjSpejl9pC@calendula>
Date: Thu, 14 Nov 2024 13:09:05 +0100
From: Pablo Neira Ayuso <pablo@...filter.org>
To: Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>
Cc: Paolo Abeni <pabeni@...hat.com>, Jeongjun Park <aha310510@...il.com>,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	horms@...nel.org, kaber@...sh.net, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	syzbot+58c872f7790a4d2ac951@...kaller.appspotmail.com
Subject: Re: [PATCH net v2] netfilter: ipset: add missing range check in
 bitmap_ip_uadt

On Thu, Nov 14, 2024 at 12:46:29PM +0100, Jozsef Kadlecsik wrote:
> On Thu, 14 Nov 2024, Pablo Neira Ayuso wrote:
> 
> > On Thu, Nov 14, 2024 at 12:10:05PM +0100, Paolo Abeni wrote:
> > > On 11/13/24 14:02, Jeongjun Park wrote:
> > > > When tb[IPSET_ATTR_IP_TO] is not present but tb[IPSET_ATTR_CIDR] exists,
> > > > the values of ip and ip_to are slightly swapped. Therefore, the range check
> > > > for ip should be done later, but this part is missing and it seems that the
> > > > vulnerability occurs.
> > > > 
> > > > So we should add missing range checks and remove unnecessary range checks.
> > > > 
> > > > Cc: <stable@...r.kernel.org>
> > > > Reported-by: syzbot+58c872f7790a4d2ac951@...kaller.appspotmail.com
> > > > Fixes: 72205fc68bd1 ("netfilter: ipset: bitmap:ip set type support")
> > > > Signed-off-by: Jeongjun Park <aha310510@...il.com>
> > > 
> > > @Pablo, @Jozsef: despite the subj prefix, I guess this should go via
> > > your tree. Please LMK if you prefer otherwise.
> > 
> > Patch LGTM. I am waiting for Jozsef to acknowledge this fix.
> 
> Sorry for the delay at acking the patch. Please apply it to the stable 
> branches too because those are affected as well.

No problem, preparing PR. Thanks Jozsef.