linux-kernel - Re: [PATCH v4 02/10] driver core: add irq_get_affinity callback device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzVX92YaqVpW9cPw@fedora>
Date: Thu, 14 Nov 2024 09:52:55 +0800
From: Ming Lei <ming.lei@...hat.com>
To: Daniel Wagner <wagi@...nel.org>
Cc: Jens Axboe <axboe@...nel.dk>, Bjorn Helgaas <bhelgaas@...gle.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Jason Wang <jasowang@...hat.com>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	Eugenio Pérez <eperezma@...hat.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Keith Busch <kbusch@...nel.org>, Christoph Hellwig <hch@....de>,
	Sagi Grimberg <sagi@...mberg.me>,
	John Garry <john.g.garry@...cle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Hannes Reinecke <hare@...e.de>, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	virtualization@...ts.linux.dev, linux-scsi@...r.kernel.org,
	megaraidlinux.pdl@...adcom.com, mpi3mr-linuxdrv.pdl@...adcom.com,
	MPT-FusionLinux.pdl@...adcom.com, storagedev@...rochip.com,
	linux-nvme@...ts.infradead.org
Subject: Re: [PATCH v4 02/10] driver core: add irq_get_affinity callback
 device_driver

On Wed, Nov 13, 2024 at 03:26:16PM +0100, Daniel Wagner wrote:
> Introducing a callback in struct device_driver so that a device driver
> can hook up the getters directly. This approach avoids exposing random
> getters in drivers.
> 
> Signed-off-by: Daniel Wagner <wagi@...nel.org>
> ---
>  include/linux/device/driver.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/device/driver.h b/include/linux/device/driver.h
> index 5c04b8e3833b995f9fd4d65b8732b3dfce2eba7e..0d1aee423f6c076ae102bdd0536233c259947fac 100644
> --- a/include/linux/device/driver.h
> +++ b/include/linux/device/driver.h
> @@ -74,6 +74,7 @@ enum probe_type {
>   * @suspend:	Called to put the device to sleep mode. Usually to a
>   *		low power state.
>   * @resume:	Called to bring a device from sleep mode.
> + * @irq_get_affinity:	Get IRQ affinity mask for the device.
>   * @groups:	Default attributes that get created by the driver core
>   *		automatically.
>   * @dev_groups:	Additional attributes attached to device instance once
> @@ -112,6 +113,8 @@ struct device_driver {
>  	void (*shutdown) (struct device *dev);
>  	int (*suspend) (struct device *dev, pm_message_t state);
>  	int (*resume) (struct device *dev);
> +	const struct cpumask *(*irq_get_affinity)(struct device *dev,
> +			unsigned int irq_vec);
>  	const struct attribute_group **groups;
>  	const struct attribute_group **dev_groups;

The patch looks fine, but if you put 1, 2 and 5 into single patch,
it will become much easier to review, anyway:

Reviewed-by: Ming Lei <ming.lei@...hat.com>


-- 
Ming