linux-kernel - Re: [PATCH] jbd2: Fix comment describing journal_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <173159220758.521904.7231961435577628717.b4-ty@mit.edu>
Date: Thu, 14 Nov 2024 08:53:34 -0500
From: "Theodore Ts'o" <tytso@....edu>
To: Daniel Martín Gómez <dalme@...eup.net>
Cc: "Theodore Ts'o" <tytso@....edu>, Jan Kara <jack@...e.com>,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jbd2: Fix comment describing journal_init_common()


On Thu, 07 Nov 2024 15:45:38 +0100, Daniel Martín Gómez wrote:
> The code indicates that journal_init_common() fills the journal_t object
> it returns while the comment incorrectly states that only a few fields are
> initialised. Also, the comment claims that journal structures could be
> created from scratch which isn't possible as journal_init_common() calls
> journal_load_superblock() which loads and checks journal superblock from
> disk.
> 
> [...]

Applied, thanks!

[1/1] jbd2: Fix comment describing journal_init_common()
      commit: 3e7c69cdb053f9edea95502853f35952ab6cbf06

Best regards,
-- 
Theodore Ts'o <tytso@....edu>