linux-kernel - Re: [PATCH] jbd2: Make b_frozen_data allocation always succeed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <173159220755.521904.4965154876627000163.b4-ty@mit.edu>
Date: Thu, 14 Nov 2024 08:53:33 -0500
From: "Theodore Ts'o" <tytso@....edu>
To: jack@...e.com, Zhihao Cheng <chengzhihao@...weicloud.com>
Cc: "Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org, chengzhihao1@...wei.com,
        yi.zhang@...wei.com
Subject: Re: [PATCH] jbd2: Make b_frozen_data allocation always succeed


On Sat, 12 Oct 2024 16:55:30 +0800, Zhihao Cheng wrote:
> The b_frozen_data allocation should not be failed during journal
> committing process, otherwise jbd2 will abort.
> Since commit 490c1b444ce653d("jbd2: do not fail journal because of
> frozen_buffer allocation failure") already added '__GFP_NOFAIL' flag
> in do_get_write_access(), just add '__GFP_NOFAIL' flag for all allocations
> in jbd2_journal_write_metadata_buffer(), like 'new_bh' allocation does.
> Besides, remove all error handling branches for do_get_write_access().
> 
> [...]

Applied, thanks!

[1/1] jbd2: Make b_frozen_data allocation always succeed
      commit: abe1ac7ca84236513a3d8ede02cc47584437f24f

Best regards,
-- 
Theodore Ts'o <tytso@....edu>