linux-kernel - Re: [PATCH 1/2] dt-bindings: iio: frequency: Add ADF4382

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <173159493449.4168533.9910621025953686531.robh@kernel.org>
Date: Thu, 14 Nov 2024 08:35:34 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Ciprian Hegbeli <ciprian.hegbeli@...log.com>
Cc: Jonathan Cameron <jic23@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
 Kim Seer Paller <kimseer.paller@...log.com>, 
 Antoniu Miclaus <antoniu.miclaus@...log.com>, 
 Michael Hennerich <Michael.Hennerich@...log.com>, 
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Lars-Peter Clausen <lars@...afoo.de>, 
 Javier Carrasco <javier.carrasco.cruz@...il.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-iio@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: frequency: Add ADF4382


On Thu, 14 Nov 2024 15:03:10 +0200, Ciprian Hegbeli wrote:
> The ADF4382A is a high performance, ultralow jitter, Frac-N PLL
> with integrated VCO ideally suited for LO generation for 5G applications
> or data converter clock applications. The high performance
> PLL has a figure of merit of -239 dBc/Hz, low 1/f Noise and
> high PFD frequency of 625MHz in integer mode that can achieve
> ultralow in-band noise and integrated jitter. The ADF4382A can
> generate frequencies in a fundamental octave range of 11.5 GHz to
> 21 GHz, thereby eliminating the need for sub-harmonic filters. The
> divide by 2 and 4 output dividers on the part allow frequencies to
> be generated from 5.75GHz to 10.5GHz and 2.875GHz to 5.25GHz
> respectively.
> 
> Signed-off-by: Ciprian Hegbeli <ciprian.hegbeli@...log.com>
> ---
>  .../bindings/iio/frequency/adi,adf4382.yaml   | 141 ++++++++++++++++++
>  1 file changed, 141 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/frequency/adi,adf4382.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/frequency/adi,adf4382.example.dtb: frequency@0: 'adi,charge-pump-current' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/iio/frequency/adi,adf4382.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241114130340.7354-2-ciprian.hegbeli@analog.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.