linux-kernel - Re: [PATCH 3/3] dt-bindings: w1: ds2482: Add vcc-supply property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241115-happy-garter-2cf65f4b1290@spud>
Date: Fri, 15 Nov 2024 18:16:32 +0000
From: Conor Dooley <conor@...nel.org>
To: cleverline1mc@...il.com
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Stefan Wahren <stefan.wahren@...rgebyte.com>,
	Ben Gardner <bgardner@...tec.com>, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: w1: ds2482: Add vcc-supply property

On Fri, Nov 15, 2024 at 03:58:06PM +0100, Kryštof Černý via B4 Relay wrote:
> From: Kryštof Černý <cleverline1mc@...il.com>
> 
> Adds the newly added vcc-supply property to bindings.

This commit message is a circular argument. You're adding it to the
binding, which of course means it is newly added.

> 
> Signed-off-by: Kryštof Černý <cleverline1mc@...il.com>
> ---
>  Documentation/devicetree/bindings/w1/maxim,ds2482.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml b/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
> index 422becc6e1fa8d58665c5586ebdc611cd0b2c760..a6b9e0658ec858cb24b21cf64443a061bb43e4ef 100644
> --- a/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
> +++ b/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
> @@ -25,6 +25,9 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  vcc-supply:
> +    description: phandle of the regulator that provides the supply voltage.

"vcc-supply: true" should suffice.

> +
>  required:
>    - compatible
>    - reg
> 
> -- 
> 2.39.5
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)