linux-kernel - Re: [PATCH 2/4] iio: adc: ad4000: Add timestamp channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c42a5815-78b0-46d0-8592-e9bbeac12e16@baylibre.com>
Date: Fri, 15 Nov 2024 11:07:11 -0600
From: David Lechner <dlechner@...libre.com>
To: Marcelo Schmitt <marcelo.schmitt@...log.com>, lars@...afoo.de,
 Michael.Hennerich@...log.com, jic23@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, marcelo.schmitt1@...il.com
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] iio: adc: ad4000: Add timestamp channel

On 11/14/24 5:50 PM, Marcelo Schmitt wrote:
> The ADC data is pushed to the IIO buffer along with timestamp but no
> timestamp channel was provided to retried the time data.
> Add a timestamp channel to provide sample capture time.
> 
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@...log.com>
> ---
> I was about to reply to the patches the other week but waited thinking I
> would be able to test them on time.
> My initial intent was to provide timestamps for ADC readings, but I didn't
> realize an IIO timestamp channel would be needed (silly me).
> David, do you want a Suggested-by tag in this one?

I supposed that would make more sense than Reported-by: if we are
calling this a feature rather than a bug. Also,

Reviewed-by: David Lechner <dlechner@...libre.com>