linux-kernel - Re: [PATCH] dt-bindings: mfd: omap-usb-tll: convert to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241115-document-skirt-1b12ae3af541@spud>
Date: Fri, 15 Nov 2024 18:42:00 +0000
From: Conor Dooley <conor@...nel.org>
To: Karol Przybylski <karprzy7@...il.com>
Cc: lee@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, andreas@...nade.info,
	rogerq@...nel.org, skhan@...uxfoundation.org
Subject: Re: [PATCH] dt-bindings: mfd: omap-usb-tll: convert to YAML

On Thu, Nov 14, 2024 at 07:58:30PM +0100, Karol Przybylski wrote:
> diff --git a/Documentation/devicetree/bindings/mfd/omap-usb-tll.yaml b/Documentation/devicetree/bindings/mfd/omap-usb-tll.yaml
> new file mode 100644
> index 000000000000..f49417d1faf7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/omap-usb-tll.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/omap-usb-tll.yaml#

ti,usbhs-tll.yaml as the filename please.

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OMAP HS USB Host TLL (Transceiver-Less Interface)
> +
> +maintainers:
> +  - <maintainer@...nel.org>

Put whoever the original author of the binding was here, failing that
probably the platform maintainers for omap.

> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,usbhs-tll
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  ti,hwmod:

Pretty sure you need a type here:
    $ref: /schemas/types.yaml#/definitions/string

> +    const: usb_tll_hs
> +
> +  clocks:
> +    minItems: 2

Please add an items list here for each clock with a description.

Where did the minItems: 2 come from? The text binding suggests that 1
would be valid.


Cheers,
Conor.

> +
> +  clock-names:
> +    items:
> +      - const: usb_tll_hs_usb_ch0_clk
> +      - const: usb_tll_hs_usb_ch1_clk
> +      - const: usb_tll_hs_usb_ch2_clk
> +    minItems: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - ti,hwmod
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    usbhstll@...62000 {
> +      compatible = "ti,usbhs-tll";
> +      reg = <0x4a062000 0x1000>;
> +      interrupts = <78>;
> +      ti,hwmod = "usb_tll_hs";
> +    };
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)