linux-kernel - Re: [PATCH] arch:x86:coco:sev: Initialize ctxt variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b243110f-d233-0b62-864e-2b6181663d29@amd.com>
Date: Fri, 15 Nov 2024 13:20:15 -0600
From: Tom Lendacky <thomas.lendacky@....com>
To: "Ragavendra B.N." <ragavendra.bn@...il.com>,
 Ingo Molnar <mingo@...nel.org>
Cc: tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com, hpa@...or.com, ardb@...nel.org,
 ashish.kalra@....com, tzimmermann@...e.de, bhelgaas@...gle.com,
 x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch:x86:coco:sev: Initialize ctxt variable

On 11/15/24 12:37, Ragavendra B.N. wrote:
> On Fri, Nov 15, 2024 at 12:01:03PM +0100, Ingo Molnar wrote:
>>
>> * Ragavendra <ragavendra.bn@...il.com> wrote:
>>
>>> Updating the ctxt value to NULL in the svsm_perform_ghcb_protocol as
>>> it was not initialized.
>>>
>>> Fixes: 2e1b3cc9d7f7 (grafted) Merge tag 'arm-fixes-6.12-2' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc
>>
>> This 'Fixes' tag looks bogus.
>>
>> Thanks,
>>
>> 	Ingo
> Please feel free to suggest the valid tag as the file was renamed and I am not able to fetch the correct commit id.
> git log --oneline arch/x86/coco/sev/shared.c
> f50cd034d24d (HEAD -> 1594023) arch:x86:coco:sev: Initialize ctxt variable
> 2e1b3cc9d7f7 (grafted) Merge tag 'arm-fixes-6.12-2' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc

A quick git annotate arch/x86/coco/sev/shared.c shows that function was
created with:

34ff65901735 ("x86/sev: Use kernel provided SVSM Calling Areas")

Thanks,
Tom

> 
> --
> Thanks,
> Ragavendra