linux-kernel - Re: [PATCH linux-next] lib/string_choices: Add str_locked_unlocked()/str_unlocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vfp++XMr8VGjjFRBpJi+uAk8PRVPxMLmQciedBzS8gedQ@mail.gmail.com>
Date: Fri, 15 Nov 2024 21:44:55 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: R Sundar <prosunofficial@...il.com>
Cc: Kees Cook <kees@...nel.org>, Andy Shevchenko <andy@...nel.org>, linux-hardening@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH linux-next] lib/string_choices: Add str_locked_unlocked()/str_unlocked_locked()
 helper

On Fri, Nov 15, 2024 at 4:47 PM R Sundar <prosunofficial@...il.com> wrote:
>
> Add str_locked_unlocked()/str_unlocked_locked() helper to return
> "locked" or "unlocked" string literal

Missing period.

...

> --- a/include/linux/string_choices.h
> +++ b/include/linux/string_choices.h
> @@ -82,4 +82,10 @@ static inline const char *str_plural(size_t num)
>         return num == 1 ? "" : "s";
>  }
>
> +static inline const char *str_locked_unlocked(bool v)
> +{
> +       return v ? "locked" : "unlocked";
> +}
> +#define str_unlocked_locked(v)         str_locked_unlocked(!(v))

The rest is sorted (okay, read_write() seems to be misplaced, fix that
in a separate change if you wish), please keep it that way (I believe
it should go before on_off).

-- 
With Best Regards,
Andy Shevchenko