linux-kernel - Re: [PATCH v4 01/10] memory: ti-aemif: Store timings parameter in number of cycles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sersmfwi.fsf@bootlin.com>
Date: Fri, 15 Nov 2024 20:54:37 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Bastien Curutchet <bastien.curutchet@...tlin.com>
Cc: Santosh Shilimkar <ssantosh@...nel.org>,  Krzysztof Kozlowski
 <krzk@...nel.org>,  Richard Weinberger <richard@....at>,  Vignesh
 Raghavendra <vigneshr@...com>,  linux-kernel@...r.kernel.org,
  linux-mtd@...ts.infradead.org,  Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>,  Herve Codina <herve.codina@...tlin.com>,
  Christopher Cordahi <christophercordahi@...ometrics.ca>
Subject: Re: [PATCH v4 01/10] memory: ti-aemif: Store timings parameter in
 number of cycles - 1

On 15/11/2024 at 14:26:22 +01, Bastien Curutchet <bastien.curutchet@...tlin.com> wrote:

> The CS configuration register expects timings to be expressed in
> 'number of cycles - 1' but they are stored in ns in the struct
> aemif_cs_data. So at init, the timings currently set are converted to ns
> by aemif_get_hw_params(), updated with values from the device-tree
> properties, and then converted back to 'number of cycles - 1' before
> being applied.
>
> Store the timings directly in 'number of cycles - 1' instead of
> nanoseconds.
> Perform the conversion from nanosecond during the device-tree parsing.
> Remove aemif_cycles_to_nsec() as it isn't used anymore.
>
> Signed-off-by: Bastien Curutchet <bastien.curutchet@...tlin.com>

Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>