| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20241115134023.6b451c18@kernel.org>
Date: Fri, 15 Nov 2024 13:40:23 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
pabeni@...hat.com, linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
donald.hunter@...il.com, horms@...nel.org, corbet@....net,
andrew+netdev@...n.ch, kory.maincent@...tlin.com
Subject: Re: [PATCH net-next v2 7/8] ethtool: remove the comments that are
not gonna be generated
On Fri, 15 Nov 2024 11:36:45 -0800 Stanislav Fomichev wrote:
> -/* MAC Merge (802.3) */
> -
> enum {
> ETHTOOL_A_MM_STAT_UNSPEC,
> ETHTOOL_A_MM_STAT_PAD,
> + ETHTOOL_A_MM_STAT_REASSEMBLY_ERRORS,
> + ETHTOOL_A_MM_STAT_SMD_ERRORS,
> + ETHTOOL_A_MM_STAT_REASSEMBLY_OK,
> + ETHTOOL_A_MM_STAT_RX_FRAG_COUNT,
> + ETHTOOL_A_MM_STAT_TX_FRAG_COUNT,
> + ETHTOOL_A_MM_STAT_HOLD_COUNT,
>
> - /* aMACMergeFrameAssErrorCount */
> - ETHTOOL_A_MM_STAT_REASSEMBLY_ERRORS, /* u64 */
> - /* aMACMergeFrameSmdErrorCount */
> - ETHTOOL_A_MM_STAT_SMD_ERRORS, /* u64 */
> - /* aMACMergeFrameAssOkCount */
> - ETHTOOL_A_MM_STAT_REASSEMBLY_OK, /* u64 */
> - /* aMACMergeFragCountRx */
> - ETHTOOL_A_MM_STAT_RX_FRAG_COUNT, /* u64 */
> - /* aMACMergeFragCountTx */
> - ETHTOOL_A_MM_STAT_TX_FRAG_COUNT, /* u64 */
> - /* aMACMergeHoldCount */
> - ETHTOOL_A_MM_STAT_HOLD_COUNT, /* u64 */
These comments could be useful to cross reference with the IEEE spec.
Can we add them as doc: ?
Powered by blists - more mailing lists