linux-kernel - Re: [PATCH net-next v2 8/8] ethtool: regenerate uapi header from the spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzfDnLG_U85X_pOd@mini-arch>
Date: Fri, 15 Nov 2024 13:56:44 -0800
From: Stanislav Fomichev <stfomichev@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Stanislav Fomichev <sdf@...ichev.me>, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	donald.hunter@...il.com, horms@...nel.org, corbet@....net,
	andrew+netdev@...n.ch, kory.maincent@...tlin.com
Subject: Re: [PATCH net-next v2 8/8] ethtool: regenerate uapi header from the
 spec

On 11/15, Jakub Kicinski wrote:
> On Fri, 15 Nov 2024 11:36:46 -0800 Stanislav Fomichev wrote:
> > +/**
> > + * enum ethtool_header_flags
> > + * @ETHTOOL_FLAG_COMPACT_BITSETS: use compact bitsets in reply
> > + * @ETHTOOL_FLAG_OMIT_REPLY: provide optional reply for SET or ACT requests
> > + * @ETHTOOL_FLAG_STATS: request statistics, if supported by the driver
> > + */
> 
> Looks like we need a doc on the enum itself here:
> 
> include/uapi/linux/ethtool_netlink_generated.h:23: warning: missing initial short description on line:
>  * enum ethtool_header_flags

"Assorted ethtool flags" as placeholder? Any better ideas? These don't seem
to have a good common purpose :-(