linux-kernel - Re: [PATCH v2 15/21] wifi: ath11k: Convert timeouts to secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d2d2c07b-666d-4b37-a428-2d73ce8aeb5b@quicinc.com>
Date: Fri, 15 Nov 2024 14:59:51 -0800
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Easwar Hariharan <eahariha@...ux.microsoft.com>,
        Pablo Neira Ayuso
	<pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        "David S.
 Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Simon Horman
	<horms@...nel.org>,
        Julia Lawall <Julia.Lawall@...ia.fr>,
        Nicolas Palix
	<nicolas.palix@...g.fr>,
        Daniel Mack <daniel@...que.org>,
        Haojian Zhuang
	<haojian.zhuang@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Russell
 King <linux@...linux.org.uk>,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily
 Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle
	<svens@...ux.ibm.com>, Ofir Bitton <obitton@...ana.ai>,
        Oded Gabbay
	<ogabbay@...nel.org>,
        Lucas De Marchi <lucas.demarchi@...el.com>,
        Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
        Rodrigo
 Vivi <rodrigo.vivi@...el.com>,
        Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Jeroen de Borst <jeroendb@...gle.com>,
        Praveen Kaligineedi <pkaligineedi@...gle.com>,
        Shailend Chand
	<shailend@...gle.com>,
        Andrew Lunn <andrew+netdev@...n.ch>,
        James Smart
	<james.smart@...adcom.com>,
        Dick Kennedy <dick.kennedy@...adcom.com>,
        "James
 E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
        "Martin K. Petersen"
	<martin.petersen@...cle.com>,
        Roger Pau Monné
	<roger.pau@...rix.com>,
        Jens Axboe <axboe@...nel.dk>, Kalle Valo
	<kvalo@...nel.org>,
        Jeff Johnson <jjohnson@...nel.org>,
        Catalin Marinas
	<catalin.marinas@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jack
 Wang <jinpu.wang@...ud.ionos.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz
	<luiz.dentz@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Florian Fainelli <florian.fainelli@...adcom.com>,
        Ray Jui
	<rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
        Broadcom internal
 kernel review list <bcm-kernel-feedback-list@...adcom.com>,
        Xiubo Li
	<xiubli@...hat.com>, Ilya Dryomov <idryomov@...il.com>,
        Josh Poimboeuf
	<jpoimboe@...nel.org>, Jiri Kosina <jikos@...nel.org>,
        Miroslav Benes
	<mbenes@...e.cz>, Petr Mladek <pmladek@...e.com>,
        Joe Lawrence
	<joe.lawrence@...hat.com>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai
	<tiwai@...e.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Russell King
	<linux+etnaviv@...linux.org.uk>,
        Christian Gmeiner
	<christian.gmeiner@...il.com>,
        Louis Peens <louis.peens@...igine.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Naveen N Rao
	<naveen@...nel.org>,
        Madhavan Srinivasan <maddy@...ux.ibm.com>
CC: <netfilter-devel@...r.kernel.org>, <coreteam@...filter.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <cocci@...ia.fr>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-s390@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <intel-xe@...ts.freedesktop.org>, <linux-scsi@...r.kernel.org>,
        <xen-devel@...ts.xenproject.org>, <linux-block@...r.kernel.org>,
        <linux-wireless@...r.kernel.org>, <ath11k@...ts.infradead.org>,
        <linux-mm@...ck.org>, <linux-bluetooth@...r.kernel.org>,
        <linux-staging@...ts.linux.dev>,
        <linux-rpi-kernel@...ts.infradead.org>, <ceph-devel@...r.kernel.org>,
        <live-patching@...r.kernel.org>, <linux-sound@...r.kernel.org>,
        <etnaviv@...ts.freedesktop.org>, <oss-drivers@...igine.com>,
        <linuxppc-dev@...ts.ozlabs.org>,
        Anna-Maria Behnsen
	<anna-maria@...utronix.de>
Subject: Re: [PATCH v2 15/21] wifi: ath11k: Convert timeouts to
 secs_to_jiffies()

On 11/15/2024 1:26 PM, Easwar Hariharan wrote:
> Changes made with the following Coccinelle rules:
> 
> @@ constant C; @@
> 
> - msecs_to_jiffies(C * 1000)
> + secs_to_jiffies(C)
> 
> @@ constant C; @@
> 
> - msecs_to_jiffies(C * MSEC_PER_SEC)
> + secs_to_jiffies(C)
> 
> Signed-off-by: Easwar Hariharan <eahariha@...ux.microsoft.com>

Acked-by: Jeff Johnson <quic_jjohnson@...cinc.com>

> ---
>  drivers/net/wireless/ath/ath11k/debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath11k/debugfs.c b/drivers/net/wireless/ath/ath11k/debugfs.c
> index 57281a135dd7fa6b8610636f47873c8bba21053c..bf192529e3fe26a91e72105a77b4c6f849b905ec 100644
> --- a/drivers/net/wireless/ath/ath11k/debugfs.c
> +++ b/drivers/net/wireless/ath/ath11k/debugfs.c
> @@ -178,7 +178,7 @@ static int ath11k_debugfs_fw_stats_request(struct ath11k *ar,
>  	 * received 'update stats' event, we keep a 3 seconds timeout in case,
>  	 * fw_stats_done is not marked yet
>  	 */
> -	timeout = jiffies + msecs_to_jiffies(3 * 1000);
> +	timeout = jiffies + secs_to_jiffies(3);
>  
>  	ath11k_debugfs_fw_stats_reset(ar);
>  
>