linux-kernel - RE: [PATCH v6 8/8] iio: adc: ad4851: add ad485x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CY4PR03MB33991C99B1BB42CFD20B18C29B242@CY4PR03MB3399.namprd03.prod.outlook.com>
Date: Fri, 15 Nov 2024 10:59:30 +0000
From: "Miclaus, Antoniu" <Antoniu.Miclaus@...log.com>
To: David Lechner <dlechner@...libre.com>,
        "jic23@...nel.org"
	<jic23@...nel.org>,
        "robh@...nel.org" <robh@...nel.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "linux-iio@...r.kernel.org"
	<linux-iio@...r.kernel.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "linux-pwm@...r.kernel.org"
	<linux-pwm@...r.kernel.org>
Subject: RE: [PATCH v6 8/8] iio: adc: ad4851: add ad485x driver


> On 11/14/24 4:39 AM, Miclaus, Antoniu wrote:
> >> On 11/11/24 6:12 AM, Antoniu Miclaus wrote:
> >>> Add support for the AD485X a fully buffered, 8-channel simultaneous
> >>> sampling, 16/20-bit, 1 MSPS data acquisition system (DAS) with
> >>> differential, wide common-mode range inputs.
> >>>
> >>> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> >>> ---
> >>> changes in v6 (implemented most of the review comments in v5):
> >> What is the plan for addressing the rest of the comments?
> > For the rest of the comments I think I replied inline in the previous series.
> >
> I didn't look very close yet, but at a quick glance, I saw that all
> scan_type are still only signed, there is no unsigned for when the
> channels are used as single-ended. And the scan_index ordering is
> still wrong. This makes me doubt that buffered reads are working
> correctly for all configurations.

Sure, will implement the scan_type as you suggested in the next series.