linux-kernel - Re: [PATCH v3] mtd: spi-nor: atmel: add at25sf321 entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D5MPWZF8NUW9.1VVRAD59LVVV2@kernel.org>
Date: Fri, 15 Nov 2024 12:32:53 +0100
From: "Michael Walle" <mwalle@...nel.org>
To: "Marcus Folkesson" <marcus.folkesson@...il.com>, "Tudor Ambarus"
 <tudor.ambarus@...aro.org>, "Pratyush Yadav" <pratyush@...nel.org>, "Miquel
 Raynal" <miquel.raynal@...tlin.com>, "Richard Weinberger" <richard@....at>,
 "Vignesh Raghavendra" <vigneshr@...com>, "Nicolas Ferre"
 <nicolas.ferre@...rochip.com>, "Alexandre Belloni"
 <alexandre.belloni@...tlin.com>, "Claudiu Beznea"
 <claudiu.beznea@...on.dev>
Cc: <linux-mtd@...ts.infradead.org>, <linux-arm-kernel@...ts.infradead.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] mtd: spi-nor: atmel: add at25sf321 entry

Hi Marcus,

On Fri Nov 15, 2024 at 12:21 PM CET, Marcus Folkesson wrote:
> Add entry for the at25sf321 32Mbit SPI flash.
>
> This flash is populated on a custom board and was tested at
> 10MHz frequency using the "ti,da830-spi" SPI controller.
>
> Link:
> https://www.renesas.com/en/document/dst/at25sf321-datasheet?r=1608801
>

Please put the URL into the same line as the link and no empty line
between your SoB and the link.

> Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>

..

> diff --git a/drivers/mtd/spi-nor/atmel.c b/drivers/mtd/spi-nor/atmel.c
> index 45d1153a04a07b7c61f46b117311b24ab695038f..ff9462d9b8ed83f44ee99a7f3b70b99b4d455e9b 100644
> --- a/drivers/mtd/spi-nor/atmel.c
> +++ b/drivers/mtd/spi-nor/atmel.c
> @@ -238,6 +238,11 @@ static const struct flash_info atmel_nor_parts[] = {
>  		.flags = SPI_NOR_HAS_LOCK,
>  		.no_sfdp_flags = SECT_4K,
>  		.fixups = &at25fs_nor_fixups
> +	}, {
> +		.id = SNOR_ID(0x1f, 0x87, 0x01),
> +		.name = "at25sf321",

No name please. As you've already found out the ID will be reused
and the name is just misleading.

> +		.size = SZ_4M,
> +		.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
>  	},
>  };

Otherwise looks good and with that above fixed:

Reviewed-by: Michael Walle <mwalle@...nel.org>

-michael