linux-kernel - Re: [PATCH] kernel/resource: Simplify API __devm_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20241114160652.442ac4d4ee437810946aefbe@linux-foundation.org>
Date: Thu, 14 Nov 2024 16:06:52 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Zijun Hu <zijun_hu@...oud.com>
Cc: linux-kernel@...r.kernel.org, Zijun Hu <quic_zijuhu@...cinc.com>,
 ",Mika Westerberg" <mika.westerberg@...ux.intel.com>, ",Andy Shevchenko"
 <andriy.shevchenko@...ux.intel.com>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Subject: Re: [PATCH] kernel/resource: Simplify API __devm_release_region()
 implementation

On Wed, 13 Nov 2024 22:07:22 +0800 Zijun Hu <zijun_hu@...oud.com> wrote:

> On 2024/10/17 23:34, Zijun Hu wrote:
> > From: Zijun Hu <quic_zijuhu@...cinc.com>
> > 
> > Simplify __devm_release_region() implementation by dedicated
> > API devres_release() which have below advantages than current
> > __release_region() + devres_destroy():
> > 
> > It is simpler if __devm_release_region() is undoing what
> > __devm_request_region() did, otherwise, it can avoid wrong and
> > undesired __release_region().
> > 
> > Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> > ---
> > linux-next tree has similar fixes as shown below:
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=0ee4dcafda9576910559f0471a3d6891daf9ab92
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=9bd133f05b1dca5ca4399a76d04d0f6f4d454e44
> > ---
> >  kernel/resource.c | 3 +--
> 
> Hi Andrew,
> 
> There are no maintainer or supporter for kernel/resource.c according to
> get_maintainer.pl.
> 
> could you please code review for this patch?

Yup, thanks, I'll toss it onto the pile for consideration after
6.13-rc1.