linux-kernel - Re: [PATCH v3 2/2] crypto: hisilicon/sec2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZzatWBNAyjsuaRP6@gondor.apana.org.au>
Date: Fri, 15 Nov 2024 10:09:28 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: "linwenkai (C)" <linwenkai6@...ilicon.com>
Cc: Chenghai Huang <huangchenghai2@...wei.com>, davem@...emloft.net,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	liulongfang@...wei.com, qianweili@...wei.com,
	wangzhou1@...ilicon.com
Subject: Re: [PATCH v3 2/2] crypto: hisilicon/sec2 - fix for aead invalid
 authsize

On Thu, Nov 14, 2024 at 08:47:11PM +0800, linwenkai (C) wrote:
>
> I have found another setup for fallback in the sec_aead_param_check
> function, so I need to fix it right too.

So you want to determine whether to use the fallback based on
the parameters of the request.  In that case I think you should
create a new fallback field in the request context.  Set its
initial value to that of the tfm context fallback variable, and
then modify it based on the request parameters.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt