linux-kernel - Re: [Regression] wifi problems since tg3 started throwing rcu stall warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <720576d090304a33b7d9ba3348056717@aosc.io>
Date: Fri, 15 Nov 2024 11:01:25 +0800
From: Mingcong Bai <jeffbai@...c.io>
To: Frederic Weisbecker <frederic@...nel.org>
Cc: "Paul E. McKenney" <paulmck@...nel.org>, Thorsten Leemhuis
 <regressions@...mhuis.info>, Linux regressions mailing list
 <regressions@...ts.linux.dev>, LKML <linux-kernel@...r.kernel.org>, rcu
 <rcu@...r.kernel.org>, sakiiily@...c.io, Kexy Biscuit <kexybiscuit@...c.io>
Subject: Re: [Regression] wifi problems since tg3 started throwing rcu stall
 warnings

Hi Frederic,

<snip>

> Just in case, Mingcong Bai can you test the following patch without the
> revert and see if it triggers something?
> 
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 35949ec1f935..b4f8ed8138d3 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -5170,6 +5170,7 @@ void rcutree_migrate_callbacks(int cpu)
>  	struct rcu_data *rdp = per_cpu_ptr(&rcu_data, cpu);
>  	bool needwake;
> 
> +	WARN_ON_ONCE(1);
>  	if (rcu_rdp_is_offloaded(rdp))
>  		return;
> 

Please find attached the dmesg with your patch (and no revert) against 
6.12-rc7.

Best Regards,
Mingcong Bai

> 
> 
> Thanks.
> 
>> 
>> 							Thanx, Paul
Download attachment "dmesg-tg3-warn-on-once.log" of type "application/json" (150070 bytes)