linux-kernel - Re: [PATCH v2 1/2] hwmon: Add Congatec Board Controller monitoring driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4eb5a59-4551-476a-aa03-06849dc9680e@bootlin.com>
Date: Fri, 15 Nov 2024 15:00:27 +0100
From: Thomas Richard <thomas.richard@...tlin.com>
To: Guenter Roeck <linux@...ck-us.net>, Jean Delvare <jdelvare@...e.com>,
 Lee Jones <lee@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
 thomas.petazzoni@...tlin.com, blake.vermeer@...sight.com
Subject: Re: [PATCH v2 1/2] hwmon: Add Congatec Board Controller monitoring
 driver

On 11/11/24 20:31, Guenter Roeck wrote:
> 
> I don't understand why this would be needed anyway. The current channel
> index is well known, so adding or subtracting a constant should do it.

My first idea to use this macro was to avoid issue if a new voltage
sensor is added in the future.

But it's useless. If in a new generation of Board Controller a voltage
sensor is added, it will be added at the end of the list.

But it doesn't exist for now, so no need to take care.

I'll just add a constant for curr sensors.

Regards,

Thomas