linux-kernel - Re: [PATCH 3/3] x86/mm: clean up unused parameters of functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3b36643-f9cd-79d1-241d-a7aaddee49b7@amd.com>
Date: Fri, 15 Nov 2024 08:27:50 -0600
From: Tom Lendacky <thomas.lendacky@....com>
To: Baoquan He <bhe@...hat.com>, linux-kernel@...r.kernel.org, bp@...en8.de
Cc: x86@...nel.org
Subject: Re: [PATCH 3/3] x86/mm: clean up unused parameters of functions

On 11/14/24 19:21, Baoquan He wrote:
> For functions memremap_is_efi_data(), memremap_is_setup_data and
> early_memremap_is_setup_data(), their parameter 'size' is not used
> and sometime cause confusion. Remove it now.
> 
> Signed-off-by: Baoquan He <bhe@...hat.com>

Reviewed-by: Tom Lendacky <thomas.lendacky@....com>

> ---
>  arch/x86/mm/ioremap.c | 17 +++++++----------
>  1 file changed, 7 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
> index 5d1b5e4a8756..71b282e5a4a0 100644
> --- a/arch/x86/mm/ioremap.c
> +++ b/arch/x86/mm/ioremap.c
> @@ -593,8 +593,7 @@ static bool memremap_should_map_decrypted(resource_size_t phys_addr,
>   * Examine the physical address to determine if it is EFI data. Check
>   * it against the boot params structure and EFI tables and memory types.
>   */
> -static bool memremap_is_efi_data(resource_size_t phys_addr,
> -				 unsigned long size)
> +static bool memremap_is_efi_data(resource_size_t phys_addr)
>  {
>  	u64 paddr;
>  
> @@ -709,14 +708,12 @@ static bool __init __memremap_is_setup_data(resource_size_t phys_addr,
>  }
>  #undef SD_SIZE
>  
> -static bool __ref memremap_is_setup_data(resource_size_t phys_addr,
> -				   unsigned long size)
> +static bool __ref memremap_is_setup_data(resource_size_t phys_addr)
>  {
>  	return __memremap_is_setup_data(phys_addr, false);
>  }
>  
> -static bool __init early_memremap_is_setup_data(resource_size_t phys_addr,
> -						unsigned long size)
> +static bool __init early_memremap_is_setup_data(resource_size_t phys_addr)
>  {
>  	return __memremap_is_setup_data(phys_addr, true);
>  }
> @@ -739,8 +736,8 @@ bool arch_memremap_can_ram_remap(resource_size_t phys_addr, unsigned long size,
>  		return false;
>  
>  	if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT)) {
> -		if (memremap_is_setup_data(phys_addr, size) ||
> -		    memremap_is_efi_data(phys_addr, size))
> +		if (memremap_is_setup_data(phys_addr) ||
> +		    memremap_is_efi_data(phys_addr))
>  			return false;
>  	}
>  
> @@ -765,8 +762,8 @@ pgprot_t __init early_memremap_pgprot_adjust(resource_size_t phys_addr,
>  	encrypted_prot = true;
>  
>  	if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT)) {
> -		if (early_memremap_is_setup_data(phys_addr, size) ||
> -		    memremap_is_efi_data(phys_addr, size))
> +		if (early_memremap_is_setup_data(phys_addr) ||
> +		    memremap_is_efi_data(phys_addr))
>  			encrypted_prot = false;
>  	}
>